search

edrlab / thorium-reader

A cross platform desktop reading app, based on the Readium Desktop toolkit
https://www.edrlab.org/software/thorium-reader/
BSD 3-Clause "New" or "Revised" License
1.86k stars 157 forks source link

Focus shifts automatically to book content when opening or closing Settings using the Left or Right View options using a screen reader #2607

Closed togregg closed 1 week ago

togregg commented 1 month ago

ISSUE - Focus shifts automatically to book content when opening or closing Settings using the Left or Right View options using a screen reader

Impact: Minor

WCAG 2.1 SC 3.2.1: On Focus (Level A)

Current Behavior:

With the left or right view enabled from book settings, when a screen reader user activates the settings button in a book, focus automatically goes back into the book. You must navigate back to the Settings button in the interface to navigate the settings options. Additionally, when you close the Settings button, focus goes into the book automatically.

Example:

Using VoiceOver navigate to the Settings button and then activate it. The options for settings will appear visually on the right side of the interface and then focus will jump back into the book.

Expected Behavior:

With the left or right view enabled from book settings, when a screen reader user activates the settings button in a book, focus stays on the Settings button.

Machine Details:

Windows

macOS

Steps to recreate:

1. Have your screen reader of choice running. 2. Launch Thorium. 3. Open a Book. 4. Using standard keyboard navigation commands for a screen reader, go the settings button and activate it.\

  1. From the display dialogue, move up to put focus on the Display Tab and then press Tab twice.
  2. You will be on the left button, now navigate to the right button and activate it.
  3. The display options are now docked to the right side of the book window and focus is on the book text.
  4. Navigate back to the Settings button and activate it.
  5. The settings options on the right side go away and focus goes back into the book.  

Video(s)/Screenshots:

Video - - Focus shifts automatically to book content when opening or closing Settings using the Left or Right View options

Recommendations:

danielweck commented 2 weeks ago

This is a known issue in Thorium but thank you for reporting details. Since Thorium version 3, some React user interface libraries were integrated to improve visuals and ergonomics, but this also introduced a number of keyboard focus issues / inconsistencies. We are working on diagnosing and fixing these regressions.

togregg commented 1 week ago

@danielweck Thanks for the update. The issue also occurs when trying to change the font size just using the keyboard (and no screen reader). It does not matter which view you use, the loss of focus issue occurs.

danielweck commented 1 week ago

closing as duplicate: https://github.com/edrlab/thorium-reader/issues/2379