search

edrlab / thorium-reader

A cross platform desktop reading app, based on the Readium Desktop toolkit
https://www.edrlab.org/software/thorium-reader/
BSD 3-Clause "New" or "Revised" License
1.86k stars 157 forks source link

Conflicts with installation of thorium web browser #2608

Closed viasux closed 2 weeks ago

viasux commented 1 month ago

I believe this installs to the same location that the web browser does, so it would be nice if the installation name could be thorium-reader instead of thorium, or if a zip release could be added.

danielweck commented 2 weeks ago

Ah, that is indeed annoying!

https://github.com/edrlab/thorium-reader/blob/9d2e3e840425b9d35292f036167148c0f1812f9f/package.json#L247

https://thorium.rocks

...my concern is that renaming the Thorium Reader executable on Linux (i.e. thorium which is currently distributed via a Debian package / installer, though it is worth noting that the AppImage has its own distinct executable name) would probably break things on the consumer side, i.e. in any deployment script that depends on the current filename.

For example: https://gitlab.com/mtyshibata/thorium-reader-snap/-/blob/main/snap/snapcraft.yaml?ref_type=heads#L19