edrlab / thorium-reader

A cross platform desktop reading app, based on the Readium Desktop toolkit
https://www.edrlab.org/software/thorium-reader/
BSD 3-Clause "New" or "Revised" License
1.86k stars 157 forks source link

[PDF] regression thorium 2 to 3 on go to page not working #2616

Closed panaC closed 1 day ago

panaC commented 1 month ago

for example : https://laws-lois.justice.gc.ca/pdf/const_e.pdf

danielweck commented 1 month ago

Well, maybe now is a timely opportunity to update Thorium's ancient revision of PDF.js?

We fork, we modify:

https://github.com/mozilla/pdf.js/compare/master...edrlab:pdf.js:master

...but we're now behind a lot of code changes:

https://github.com/edrlab/pdf.js/compare/master...mozilla%3Apdf.js%3Amaster

Some Thorium-specific guidance to build the distributed Javascript payload that Thorium loads at runtime:

https://github.com/edrlab/pdf.js/blob/master/THORIUM_BUILD.md

https://github.com/edrlab/pdf.js/blob/master/TYPESCRIPT_TYPE_DEFINITIONS.md

===> https://github.com/edrlab/thorium-reader/tree/develop/src/resources/lib/pdfjs

panaC commented 1 week ago

Sure! Can I have a look ?

danielweck commented 1 week ago

yes please :) (you wrote the event bridge, so you will know where to look ;)

panaC commented 2 days ago

From my test with on DEVELOP branch latest commit, the "go to page" seems to work. Tested with 3 pdf (const and intel x86). I cannot remember why i filled this issue. This issue is comming from Laurent, but I thought that i've reproduced it on my machine. Anyway @danielweck can you test on your machine with some other pdf file ? If it's work, let's close the issue.

danielweck commented 1 day ago

Works at my end.