search

edrlab / thorium-reader

A cross platform desktop reading app, based on the Readium Desktop toolkit
https://www.edrlab.org/software/thorium-reader/
BSD 3-Clause "New" or "Revised" License
1.86k stars 157 forks source link

Daisy2.02 issue with several audio tags in <seq> #2624

Closed oscarlcarlsson closed 3 weeks ago

oscarlcarlsson commented 3 weeks ago

If a Daisy2.02 file includes sequence tags with more than one audio-tag, the first audio-tag is played and the following are ignored. This leads to audio glitches in the played file.

In the example below you only get the first half second of the audio, then it jumps to the following par-tag.

Example: `

<seq>
    <audio src="026_2_1_A_Note_on_Python_Versi.mp3" clip-begin="npt=7.319s" clip-end="npt=7.863s" id="audio_0004"/>
    <audio src="026_2_1_A_Note_on_Python_Versi.mp3" clip-begin="npt=7.863s" clip-end="npt=10.083s" id="audio_0005"/>
    <audio src="026_2_1_A_Note_on_Python_Versi.mp3" clip-begin="npt=10.083s" clip-end="npt=12.970s" id="audio_0006"/>
    <audio src="026_2_1_A_Note_on_Python_Versi.mp3" clip-begin="npt=12.970s" clip-end="npt=14.289s" id="audio_0007"/>
    <audio src="026_2_1_A_Note_on_Python_Versi.mp3" clip-begin="npt=14.289s" clip-end="npt=17.759s" id="audio_0008"/>
</seq>

`

As per the daisy 2.02-specification, this should be allowed.

See attached file for reference. epub_testfil_camabo_daisy_source.zip

danielweck commented 3 weeks ago

Thank you very much for reporting this. Fixed via: