search

edrlab / thorium-reader

A cross platform desktop reading app, based on the Readium Desktop toolkit
https://www.edrlab.org/software/thorium-reader/
BSD 3-Clause "New" or "Revised" License
1.86k stars 157 forks source link

fix(i18n): remove untranslated title attribute from General settings tab #2651

Closed naglis closed 1 week ago

naglis commented 1 week ago

This value is not translated and is being displayed as the tooltip when hovering on any element in the "General" settings tab:

Screenshot displaying the tooltip with the untranslated word "General" while hovering on an element in the "General" settings tab while Thorium is set to use the Lithuanian language

As the other tabs do not have a title attribute, I've elected to remove it instead of introducing the title attribute to other tabs.

danielweck commented 1 week ago

Thank you for spotting this error and for submitting a Pull Request, much appreciated :)