search

edrlab / thorium-reader

A cross platform desktop reading app, based on the Readium Desktop toolkit
https://www.edrlab.org/software/thorium-reader/
BSD 3-Clause "New" or "Revised" License
1.79k stars 154 forks source link

reader view, navigation (TOC), "title"-only headings should not be clickable, should be inert. #520

Closed danielweck closed 5 years ago

danielweck commented 5 years ago

Links without destination hrefs are correctly rendered (visually differentiated), however they should also be totally inert. Right now, they respond to mouse hover, display a hand cursor which indicates clickability. Nothing happens when clicking. However, when using the keyboard the links can be activated and a web browser window is opened to load the external link!! (because of undefined value at the end ... not sure what it going on exactly, but it's a bug :)

Compare Thorium / readium-desktop with r2-testapp-js:

ThoriumNav1

ThoriumNav2

danielweck commented 5 years ago

Test file: moonstone.epub from https://1drv.ms/f/s!An5Z79wj5AZBgpFAxdv8z4Fo_z3ijw

See: https://github.com/w3c/publ-epub-revision/issues/1283#issuecomment-513469723

danielweck commented 5 years ago

Interestingly, good old Readium1 web/cloud reader renders the TOC with clickable and usable top-level chapter links:

ThoriumNav3

danielweck commented 5 years ago

These ones are a variant with a different TOC: http://www.feedbooks.com/book/3311/the-moonstone https://www.gutenberg.org/ebooks/155 In this case, the headers are clickable and function as normal links (they should not be inert, because their href is valid)