Fix bug in SSE2 version of fast detector

edrosten / libcvd

libcvd - efficient and easy to use C++ computer vision library.

Other

239 stars 103 forks source link

Fix bug in SSE2 version of fast detector #47

Closed jlblancoc closed 5 years ago

jlblancoc commented 5 years ago

Hi, @edrosten, Thanks for your great library! :+1:

Please, take a look at these two commits: one is a minor fix to -Wshadow warnings, but the important one is the fix to what seems a bug in the SSE2 code for faster. The bug would reveal only if width!=stride, which might explain it went unnoticed (?). However, I can't explain the 3 in 3*w for grayscale images, so I set it to row_stride() anyway.

edrosten commented 5 years ago

Thanks for the bug report. Turns out stride is the stride for 3 rows at once. I've fixed it in this PR:

https://github.com/edrosten/libcvd/pull/48