search

edrosten / libcvd

libcvd - efficient and easy to use C++ computer vision library.
Other
238 stars 103 forks source link

update code to make it compatible with C++17 #92

Closed thachdo closed 8 months ago

thachdo commented 8 months ago

It seems ubuntu 16.04 is quite old. This PR is to make the source compatibility with C++17, which can be compiled in later ubuntu versions. Maybe need to update the README as well.

edrosten commented 8 months ago

Which system does this help for?

My system compiler is G++11 which has C++17 by default. The _v variants were added in C++17, so they should be fine with any C++17 compliant compiler.

The README is a little out of date.

thachdo commented 8 months ago

Which system does this help for?

The default g++ version of ubuntu 16.04 is 5.4, which doesn't support c++ 17 as default. This PR makes the source directly compatible with the compiler of later ubuntu versions (I tested in 18.04).

edrosten commented 8 months ago

The README is old, I don't really support 16.04 any more, officially.

Which compiler version do you need the patch for? The main version compiles just fine on GCC 11