search

edscott / xffm

GNU General Public License v3.0
3 stars 0 forks source link

gtk 3.24 dependency + UI feedback #1

Open ryanthomas-org opened 4 years ago

ryanthomas-org commented 4 years ago

Attempting to download the latest stable release from late last year.

Using Mint 19.x (Ubuntu 18.04-derivative, the current LTS release) the latest supported version of GTK is 3.22.30 – Several minutes searching online yields little interest or sympathy for those looking to build GTK 3.24, and I see some warnings against doing so. Apparently "bumped" dependencies are one major impediment. https://gitlab.gnome.org/GNOME/gtk/blob/gtk-3-24/NEWS

Are the differences between gtk 3.22.30 and 3.24 insignificant enough that I could perhaps modify certain files in the source to override the dependency check?

I love rodent but upgrading an otherwise relatively modern version of such a critical system without documentation by others who might have done so, might be overkill.

Interested in any advice you might have.

Cheers

ryanthomas-org commented 4 years ago

I modified line find_package(GTK3 3.24.1 REQUIRED) in CMakeLists.txt to 3.22.1 -- I can compile and run xffm without errors; of course I remain for now uncertain as to whether any of the various apparent reductions of UI features from rodent (librfm-5.3.16.4) are in fact related to GTK-version problems. Many icons for now do not display like before. I will enjoy tinkering with this, thanks

edscott commented 4 years ago

Thank you for your interest in this project. Gtk+-3.22,x is the absolute minimum requirement, but 3.24.x is recommended since it will remain there.

The missing UI features in xffm+ with regard to rodent are due to the fact the the whole code is being migrated from C99 to template based generic programming C++17. This change allows for smaller and faster binaries and greater error control on compilation. As this migration is gradual, the most important (for me) characteristics are being incorporated first.

Currently not all features are available if you do not compile with the ALPHA directive (export CXXFLAGS=-DALPHA before cmake). As the next release comes, current ALPHA items will be compiled by default and new ALPHA items will be introduced.

Current ALPHA items include (in testing mode):

To be coded next:

What other UI feature from rodent do you think would be nice to keep?

regards

ryanthomas-org commented 2 months ago

Sorry for the delay I took a long nap.

See freshly recompiled rodent-5.3.16.3 vs recent git clone -- on newer install with GTK 3.24.33 this time

https://github.com/user-attachments/assets/5571b03c-a359-44eb-b6c8-084242d93392

To point out exactly what I had in mind, I always found these separate icon and icon-label highlight on mouse-over features to be endearing in a bizarre way that I always appreciated. It feels like a silly request, I just think it would be neat to have that back.

On xffm, I can't really make out what the icon is doing on hover.

Also, the default theme is not detected -- I don't have a great eye for C -- is there a relatively easy way I can fix that either in the xffm+/settings.ini config file or in the code base?

Also, if I try to click any options under Hamburger Menu > Color Settings, the program locks up and I have to kill it.

Thanks for your time and this neat project. All the best

edscottwilsongarcia commented 2 months ago

Hi, Currently work is on migration to gtk4, which will again have the separate icon/label highlight, and again allow direct renaming of files. The crash you experience on the popup menu is probably due to a hard to find bug in the mouse motion event callback. An uninitialized variable could cause a crash when pointer crossed the window (as when moving from the main menu to reach the color settings dialog). This bug really troubled me because it was not easily reproduced. It was finally fixed in commit bf1abcb52: `commit 702e9c0c9ed14f00a7659a3b83d54b0bf1abcb52 Author: Dr. Edscott Wilson Garcia edscott@arch0 Date: Fri Jul 5 13:21:40 2024 -0600

DnD fixes and enhancements.

1. Fixed the sporadic drag event which caused infrecuent crash
2. On multiple selection drops, query for cp/mv/ln. This to avoid moving or copying many files by dnd without confirmation.
3. Use gtk standard for dnd, which is cp for button 1, unless +shift for mv and +shift/control for link.
4. Use button 2 (wheel button) for mv. +shift/control not active for button 2. Multiple selection drop confirmation applies to both button 1 and 2.
5. Fixed the overwrite confirmation dialog with "overwrite/cancel" instead of cryptic "yes/close"

` Gtk3 and gtk4 are now separated. To compile gtk3 version, go to the gtk3 subdirectory and there do the cmake routine. The gtk4 version is work in progress.

Thank you for your interest in xffm.