When start offset is not multiple of pagesize, it will still success at mapping, but will fail by invalid argument when unmap, which is not help user to debug.
Thanks again! I should get some kind of builder/test runner going on here to catch those silly mistakes. I could have easily missed it in my review as well.
When start offset is not multiple of pagesize, it will still success at mapping, but will fail by
invalid argument
when unmap, which is not help user to debug.