Closed bheni closed 5 years ago
Thank you, but I went ahead and merged #17 which fixes this and also adds Travis CI so things shouldn't break again in such an obvious way.
Awesome. I'm just happy to have it fixed... Though I don't understand why you would want to allow windows.FlushViewOfFile to be called if it's not writable. I would think the entirety of the flush function should be skipped.
Currently the tests don't even pass for windows. Failure output:
This change simply skips flushing if the file was opened as rdonly