fresh install fails on icu

edsu / anon

tweet about anonymous Wikipedia edits from particular IP address ranges

Creative Commons Zero v1.0 Universal

973 stars 152 forks source link

fresh install fails on icu #162

Closed remagio closed 6 years ago

remagio commented 6 years ago

Hi, I would tweets screenshots too so I did a fresh install in some instances. All fails if icu isn't yet installed. On Debian it require a apt-get install libicu-dev before npm install.

At github.com/mooz/node-icu-charset-detector there are some more OSs statements. A readme update or a setup fix? I bet the first.

grahamrichard commented 6 years ago

Having the same problem on macOS 10.12.6. I used brew install icu4c brew link icu4c --force as described here and it worked for me

edsu commented 6 years ago

I believe that your build actually succeeds since node-icu-charset-detector is an optional dependency for irc which is a dependency of wikichanges, which is (finally) a dependency of anon. The install looks a bit messy, but it reports success, and anon works fine.

Some day I guess it will make sense to move anon over from using the update messages in IRC to use the EventStream API, which will remove the irc dependency from wikichanges.