search

edsu / pymarc

process MARC records from Python
http://python.org/pypi/pymarc
Other
251 stars 99 forks source link

Fix examples of readme commands and Add readme pt_br #137

Closed souzaluuk closed 5 years ago

souzaluuk commented 5 years ago

Problem related in issue #136.

souzaluuk commented 5 years ago

Considering the as_json() function, why don't we have parse_json_to_array, similar to the xml function?

I added this function in 0452948 with some tests, what do you think?

Wooble commented 5 years ago

Thanks a lot for the fixes to the existing docs, and the translation!

I sort of wonder if gettext is a better way to provide translations than to translate the entire README.

Looking over this I notice that we're still suggesting that people run python setup.py install to install from a local copy, which even setuptools doesn't recommend anymore; pip should be used to install always, including from a local checkout. The reason I mention this here is that if I fix that in the English README, the translated README won't pick it up.

On the other hand, I have no experience with actually using gettext with sphinx to i18n docs and it may very well be extremely annoying to actually do it, so unless someone does have experience and is going to claim it's actually quite easy, I'm not going to insist on a change to start doing that.