search

edsu / pymarc

process MARC records from Python
http://python.org/pypi/pymarc
Other
251 stars 99 forks source link

Py38 support #143

Closed Wooble closed 4 years ago

Wooble commented 4 years ago

Total kludge to fix #142

python 3.8 seems to actually give you XML attributes in the order you add them; previous versions seem to be sorting them? This would add them in the odd order our test is expecting them to be in, and makes the output XML bytewise-consistent between python versions.

(I'm not sure it's reasonable to expect the attributes in a specific order, especially the odd order we do expect where the indicators come after the tag, though. Semantically it's all the same anyway.)

petrus-v commented 4 years ago

not sure the review process ! for sure I give my :+1: on this one !