search

edsu / pymarc

process MARC records from Python
http://python.org/pypi/pymarc
Other
251 stars 99 forks source link

Mutable leader #146

Closed herrboyer closed 4 years ago

herrboyer commented 4 years ago

Here's the follow up to https://github.com/edsu/pymarc/issues/108.

Almost nothing was broken after replacing the leader value in Record from a string to this Leader object except serialization.

edsu commented 4 years ago

@herrboyer did you see the test failure under python2? I didn't take a close look, but will this PR require Python3?

herrboyer commented 4 years ago

No @edsu I don't think this PR requires py3 but I had to fix a few things to make it compatible with py2, should be good now !

Wooble commented 4 years ago

To be honest if we're going to make a backwards-incompatible major release after the py2 EOL, dropping py2 support seems pretty reasonable...

herrboyer commented 4 years ago

@Wooble thanks, I fixed the missing new line and another linting error.