search

edsu / pymarc

process MARC records from Python
http://python.org/pypi/pymarc
Other
252 stars 98 forks source link

Python3 #149

Closed edsu closed 4 years ago

edsu commented 4 years ago

I think we can drop python2 support now that is no longer being maintained. This amounts to removing our use of the six module, and pymarc will have no dependencies afterwards!

Wooble commented 4 years ago

Probably a good time to stop supporting EOL'ed py3 versions, too. 3.3 and 3.4 are both unsupported. dropping 3.5 too would be nice since f-strings are so nice, but it's technically still eligible for security bugfixes until September.

herrboyer commented 4 years ago

Dropping 3.5 will also let us use proper typing instead of using comments :

    # py3.5
    def foo(self, bar):
        # type: (str) -> str
        return bar

    # py3.6
    def foo(self, bar: str) -> str:
        return bar
termim commented 4 years ago

IMHO it is good time for this. Please consider PR #152 as a first step.

edsu commented 4 years ago

Fixed by #152!