edsu / wikichanges

a NodeJS library for monitoring changes on Wikipedia sites
https://npmjs.org/package/wikichanges
70 stars 17 forks source link

IRC bot keeps being kicked #1

Closed waldyrious closed 10 years ago

waldyrious commented 10 years ago

The IRC stream is full of entries like these:

== wikichanges-927f168d-d0c7-4c8e-8d23-3f748a1da011 [~nodebot@anonymous.user] has joined
== wikichanges-927f168d-d0c7-4c8e-8d23-3f748a1da011 [~nodebot@anonymous.user] has quit (Excess Flood)

(see also edsu/wikistream#34)

edsu commented 10 years ago

I've noticed that the updates are not streaming in the application as they used to. I attributed this to some change in the Wikimedia infrastructure, but have not followed up to see what is going on.

How did you happen to notice the Excess Flood messages? Where are you running your bot? The discussion of Excess Flood here makes it sound like the wikichanges bot is sending messages and being kicked, but I thought that wikichanges only listened for changes. Perhaps there are only so many messages it can buffer to receive?

I noticed that if you connect to one channel it seems fine:

w = new wikichanges.WikiChanges({
    ircNickname: config.ircNickname,
    wikipedias: ["#en.wikipedia"]
});

But when you attempt to connect to all ~ 30 Wikipedias (the default) it seems to get jammed up.

nemobis commented 10 years ago

This error is typically noticed by humans idling in those channels, we got several complaints about it but the ops said they can't do anything about it.

This usually happens when you join too many channels too quickly, due to a vicious circle of rejoining. Just add a throttle of some seconds between rejoins and the vicious circle should stop.

wikimedia-tech.log:2014-04-23 21.50 < masti> does anybody kno w who runs this IRC bot on #wikipedia-pl : wikichanges-862e8055-c08d-44b8-ba08-d0cdbf8c6e46

wikimedia-tech.log:2014-05-11 14.05 < Sarrus> wikichanges-2905b99b-706a-4847-8ab2-baf0adb6f4bc

wikimedia-tech.log:2014-05-11 14.07 < valhallasw> wikichanges seems to be https://github.com/edsu/wikichanges

wikimedia-tech.log:2014-05-20 13.14 < coet|cawiki> i think hat user wikichanges---- is a malicious bot, that only join channel to flood

wikimedia-tech.log:2014-05-20 13.21 < coet|cawiki> i would suggest to ban it with wikichanges-----_!~nodebot@anonymous.user

wikimedia-stewards.log:2014-05-17 14.14 < Simeondahl> A bot called: wikichanges-eb756b7f-0af6-42bd-813d-47a84fa1a73d

wikimedia-stewards.log:2014-05-17 14.24 < Wiki13> wikichanges is a bot that hangs around on the Wikimedia IRC for a tool

wikimedia-stewards.log:2014-05-20 15.52 < anskar> wikichanges-bf5a6c68-7bd8-4fcf-b331-2912f3fb013a (~nodebot@anonymous.user)

wikimedia-stewards.log:2014-05-20 15.53 < anskar> it's possible block wikichanges-----_!~nodebot@anonymous.user ?

wikimedia-stewards.log:2014-05-20 15.55 < Krenair> May 17 15:44:54 [15:30:37] to clarify: Simeondahl earlier meant that "wikichanges-de567142-d148-47ea-ad13-4d2653ae31e5" bot is coming and going (Excess Flood) on Mediawiki's IRC-channels (irc.wikimedia.org)

wikimedia-operations.log:2014-05-17 16.30 < Stryn> to clarify: Simeondahl earlier meant that "wikichanges-de567142-d148-47ea-ad13-4d2653ae31e5" bot is coming and going (Excess Flood) on Mediawiki's IRC-channels (irc.wikimedia.org)

wikimedia-operations.log:2014-05-20 15.57 < anskar> the bot now is wikichanges-bf5a6c68-7bd8-4fcf-b331-2912f3fb013a (~nodebot@anonymous.user)

wikimedia-operations.log:2014-05-20 15.58 < anskar> it's possible block wikichanges-----*!~nodebot@anonymous.user ?

wikimedia-labs.log:2014-06-07 13.17 < Danny_B> and who runs wikichanges-aed12128-c392-418e-8d9d-d0eda42a22fb ?

edsu commented 10 years ago

So perhaps putting a sleep between joining channels will help ...

waldyrious commented 10 years ago

Just to confirm what nemobis said, yes, I noticed those messages by manually joining the channel (after visiting wikistream failed to produce the stream I wanted to take a look at).