search

edtalmadge / Agile-Carousel

JQuery Slideshow/Carousel Plugin
http://www.agilecarousel.com
150 stars 105 forks source link

missing first group button #3

Open dvrhijn opened 13 years ago

dvrhijn commented 13 years ago

Settings:

multiple_slides_visible, group_numbered_buttons, number_slides_visible: 1, transition_type: "fade"

The first group button does not appear until I modify line 119 for the calculation of curr_num, and remove the "+1" at the end.

That might break other set-ups but in my case the button for the first pic appears again correctly, as well as the others!

Agile Carousel v alpha 1 jquery-1.5.1

edtalmadge commented 13 years ago

I'll fix this for the next version.

Just curious, why do you use group_numbered_buttons with 1 slide visible? I was expecting that group_numbered_buttons would be used only with multiple slides visible.

dvrhijn commented 13 years ago

It functions more like an indicator this way of how large the slideshow will be, with the added possibility to skip through them in some unlinear fashion. And on a busy page it's nicer to have only one picture showing at the time.

On 07/09/2011 04:33 PM, edtalmadge wrote:

I'll fix this for the next version.

Just curious, why do you use group_numbered_buttons with 1 slide visible? I was expecting that group_numbered_buttons would be used only with multiple slides visible.

mosalski commented 13 years ago

For me it was easy to fix: agile_carousel.alpha.js - line 121 before: var curr_num = Math.floor((i + 1) / number_slides_visible) * number_slides_visible + 1; after: var curr_num = Math.floor((i + 1) / number_slides_visible) * number_slides_visible;

This makes first page to be shown, please leave a comment here in case you have found any disadvantages of this solution.