edtechhub / zotero-edtechhub

https://github.com/edtechhub/zotero-edtechhub/projects/4
12 stars 3 forks source link

attachment merging behaviour #89

Closed retorquere closed 8 months ago

retorquere commented 10 months ago

I was under the impression that Zotero would always preserve all attachments when doing a merge. However, I've noticed some cases recently, where this doesn't seem to be the case.

Item 1:

If those items are merged, then only one PDF is retained. My preference would be for both to be retained: At the very least it's confusing that one of the files disappears...

However, in some cases there's more manifest loss of information:

Item 1:

If those two are merged, only one of the links stays.

In a merge, is it intended behaviour that Zotero performs a check as to whether attachments are the same (or similar) and therefore doesn't move them to the new item?

retorquere commented 10 months ago

@bjohas the anti-merge features goes on here. It's not as simple as I thought, but I think I can get there.

bjohas commented 10 months ago

Thank you!

github-actions[bot] commented 10 months ago

:robot: this is your friendly neighborhood build bot announcing test build 0.0.37.89.18 ("bootstrap-capable monkey-patch")

Install in Zotero by downloading test build 0.0.37.89.18, opening the Zotero "Tools" menu, selecting "Add-ons", open the gear menu in the top right, and select "Install Add-on From File...".

retorquere commented 10 months ago

Still pretty simple in the end. Build 18 should do it.

bjohas commented 9 months ago

Thank you - apologies, I'd missed the update! I've tested and it works - many thanks!

It does seem to produce two item history notes, which is a little strange.

Otherwise, we're good to release!

bjohas commented 9 months ago

Incidentally, on the current release (2 weeks ago), I get "incompatible with Zotero 7". However, if I get the build associated with this issue, that compatibility issue is gone. So I assume the most current build hasn't been released?

Many thanks!

github-actions[bot] commented 9 months ago

:robot: this is your friendly neighborhood build bot announcing test build 0.0.37.89.19 ("forgot Bjoern2B")

Install in Zotero by downloading test build 0.0.37.89.19, opening the Zotero "Tools" menu, selecting "Add-ons", open the gear menu in the top right, and select "Install Add-on From File...".

retorquere commented 9 months ago

Incidentally, on the current release (2 weeks ago), I get "incompatible with Zotero 7". However, if I get the build associated with this issue, that compatibility issue is gone. So I assume the most current build hasn't been released?

It hasn't, no, I thought you wanted these released combined. I can put out a new release but if I understand the history thing right that shouldn't be hard to fix (FLW).

It does seem to produce two item history notes, which is a little strange.

I think that's because one of the merged items already had a history note, and the merge creates a new one. I can see if I can tack the history onto an existing note after the merge.

bjohas commented 9 months ago

My bad - the behaviour is as expected. I was wrong about thw two history notes, you're right!

Please release!

retorquere commented 9 months ago

You don't want me to merge the history notes?

retorquere commented 9 months ago

1.0.1 is out