search

edtechre / pybroker

Algorithmic Trading in Python with Machine Learning
https://www.pybroker.com
Other
2.09k stars 262 forks source link

Dev #111

Closed albertandking closed 8 months ago

albertandking commented 8 months ago
  1. format pyproject.toml to run CI
  2. add ignore E402 and tests fold
albertandking commented 8 months ago

Hi Ed, I have tested it through github action CI, It will be fine now

edtechre commented 8 months ago

Hi Albert, it looks this causes the schedule run to fail for some reason. Any ideas? I will look into it.

albertandking commented 8 months ago

Hi Albert, it looks this causes the schedule run to fail for some reason. Any ideas? I will look into it.

Hi Ed，I have just test it on my master branch of pybroker, but it runs fine. you can check my https://github.com/albertandking/pybroker/actions/runs/8532047906; can you rerun all actions?

edtechre commented 8 months ago

If you run "ruff src tests" it appears to fail. main.yml will only run ruff on src.

edtechre commented 8 months ago

Also, it would be good to run the ruff formatter on both tests and init.py

albertandking commented 8 months ago

Also, it would be good to run the ruff formatter on both tests and init.py

yes, I have turn off ruff run on init and tests in pyproject.toml

edtechre commented 8 months ago

Added per-file-ignores to pyproject.toml

albertandking commented 8 months ago

Added per-file-ignores to pyproject.toml

I have fix the schedule.yml the same as main.yml for ruff, it will be ok?

edtechre commented 8 months ago

Hi Albert, thanks, but I think I've fixed this.