eduNEXT / edunext-platform

Open edX, the project that powers edunext.co
https://www.edunext.co
GNU Affero General Public License v3.0
29 stars 7 forks source link

fix(DS-355): update translations #723

Closed Henrrypg closed 1 year ago

Henrrypg commented 1 year ago

This PR is to update translations (Rework for https://edunext.atlassian.net/browse/DS-317 and https://github.com/eduNEXT/edunext-platform/pull/710)

For some reason the command make pull_translations is not working as expected. This command is not pulling some translations like ''Course Tools", "Don't forget to add a calendar reminder!", etc. Due to i18n_tool generate --verbose 1 command

I tested using the following commands and its appear to works fine.

git clean -fdX conf/locale
i18n_tool transifex pull
i18n_tool extract
i18n_tool dummy
git clean -fdX conf/locale/rtl
git clean -fdX conf/locale/eo
i18n_tool validate --verbose
paver i18n_compilejs
./manage.py lms compilemessages
./manage.py cms compilemessages

How to test

Having tenant with lang switcher

example:

{
    "EDNX_USE_SIGNAL": true,
    "FEATURES": {
        "SHOW_FOOTER_LANGUAGE_SELECTOR": true,
        "SHOW_HEADER_LANGUAGE_SELECTOR": true,
        "USE_REDIRECTION_MIDDLEWARE": true
    },
    "LANGUAGE_CODE": "es",
    "LMS_BASE": "site1.nuez.edunext.link:8000",
    "SITE_NAME": "site1.nuez.edunext.link",
    "footer_langselector": true,
    "header_langselector": true,
    "header_links": [
        {
            "target": "_self",
            "txt": "Courses",
            "url": "/courses"
        },
        {
            "class": "mx-2",
            "target": "_self"
        }
    ],
    "released_languages": "en,ru,fr,es-419"
}

Navigate through the platform looking the translations.

JuanDavidBuitrago commented 1 year ago

Hi @Henrrypg, I tested it and with these changes the translations are working. But some unit test fail.

MaferMazu commented 1 year ago

Hi @Henrrypg, thanks for taking my feedback into account. I can see you can compile and update the *.mo; it may be a good idea to update the PR or leave a comment on how you do it. On the other hand, I see the command changes the .tx/config permission, maybe it is a good idea to maintain the previous permissions, and the command deletes some languages; if Service Delivery doesn't have a problem with that, is okay 🤗

cc @Ian2012

Henrrypg commented 1 year ago

@MaferMazu Some languages are not working properly, in this image you can look the comparison between limonero and nuez. I was talking with @DonatoBD about that and it seems that there is no problem.

image

Henrrypg commented 1 year ago

Hi @Henrrypg, thanks for taking my feedback into account. I can see you can compile and update the *.mo; it may be a good idea to update the PR or leave a comment on how you do it. On the other hand, I see the command changes the .tx/config permission, maybe it is a good idea to maintain the previous permissions, and the command deletes some languages; if Service Delivery doesn't have a problem with that, is okay hugs

cc @Ian2012

Thank you @MaferMazu i just squash commits and delete changes from .tx/config

DonatoBD commented 1 year ago

LGTM!