Closed Henrrypg closed 1 year ago
Hi @Henrrypg, I tested it and with these changes the translations are working. But some unit test fail.
Hi @Henrrypg, thanks for taking my feedback into account. I can see you can compile and update the *.mo; it may be a good idea to update the PR or leave a comment on how you do it. On the other hand, I see the command changes the .tx/config permission, maybe it is a good idea to maintain the previous permissions, and the command deletes some languages; if Service Delivery doesn't have a problem with that, is okay 🤗
cc @Ian2012
@MaferMazu Some languages are not working properly, in this image you can look the comparison between limonero and nuez. I was talking with @DonatoBD about that and it seems that there is no problem.
Hi @Henrrypg, thanks for taking my feedback into account. I can see you can compile and update the *.mo; it may be a good idea to update the PR or leave a comment on how you do it. On the other hand, I see the command changes the .tx/config permission, maybe it is a good idea to maintain the previous permissions, and the command deletes some languages; if Service Delivery doesn't have a problem with that, is okay hugs
cc @Ian2012
Thank you @MaferMazu i just squash commits and delete changes from .tx/config
LGTM!
This PR is to update translations (Rework for https://edunext.atlassian.net/browse/DS-317 and https://github.com/eduNEXT/edunext-platform/pull/710)
For some reason the command
make pull_translations
is not working as expected. This command is not pulling some translations like ''Course Tools", "Don't forget to add a calendar reminder!", etc. Due toi18n_tool generate --verbose 1
commandI tested using the following commands and its appear to works fine.
How to test
Having tenant with lang switcher
example:
Navigate through the platform looking the translations.