eduNEXT / eox-core

eox-core is a plugin to extend the core functionality in Open edX
GNU Affero General Public License v3.0
15 stars 9 forks source link

["FEAT"] allow to add custom params to sentry #247

Closed Ian2012 closed 1 year ago

Ian2012 commented 1 year ago

I need to enable profiling with the sentry integration, but it makes sense if there would be a way to pass custom params to the sentry integration.

The profiling integration is enabled using:

sentry_sdk.init(
  # ... SDK config
  _experiments={
    "profiles_sample_rate": 1.0,
  }
)

Describe the solution you'd like There es a dictionary that is passed as **kwargs to the sentry integration:

https://github.com/eduNEXT/eox-core/blob/master/eox_core/settings/production.py#L144

Describe alternatives you've considered If I'm wrong and there would be a better option or alternative to integrate please let me know.

JuanDavidBuitrago commented 1 year ago

Hi @Ian2012, thanks for your participation

This issue will be passed for product review @santiagosuarezedunext

santiagosuarezedunext commented 1 year ago

On it 👍

santiagosuarezedunext commented 1 year ago

@Ian2012 me comentas que necesitas profiles para saber que consume más recursos en la plataforma ¿tienen alguna iniciativa o proyecto en el que esta data hace parte?

Ian2012 commented 1 year ago

@santiagosuarezedunext It's part of the constant monitoring of the service

santiagosuarezedunext commented 1 year ago

@Ian2012 porfa dejame acá la explicación que me contabas sobre como podrian ser los parametros cusotm. Creo que si esto hace parte de su día a día deberías ejecutarlo, lo voy a mover a inpregress y se le podrá hacer siguimiento en nuestros sprints en este link de Jira

Ian2012 commented 1 year ago

We can use a setting like that is passed as a **kwargs to the sentry integration:

SENTRY_EXTRA_PARAMS = {
    "_experiments": { "profiles_sample_rate": 1.0, },
    ...
}