search

eduNEXT / eox-tenant

Plugin for managing multiple tenants (organizations) within a single Open edX instance.
GNU Affero General Public License v3.0
7 stars 4 forks source link

refactor: remove DarkLang middleware because it is not being used #186

Closed luisfelipec95 closed 1 year ago

luisfelipec95 commented 1 year ago

Description

Changes made to the PR https://github.com/eduNEXT/eox-tenant/pull/184 are made as the DarkLang middleware is no longer being used, detailed in the following discussion: https://discuss.overhang.io/t/howto-enable-multiple-languages-for-your-open-edx-platform/140.

Attached is evidence from SD where they are removing DarkLang Middleware:

Screenshot from 2023-07-05 18-19-56

luisfelipec95 commented 1 year ago

I'm not exactly sure why, but as a consequence of this PR https://github.com/eduNEXT/edunext-platform/pull/697 the middleware is being modified here https://github.com/eduNEXT/edunext-platform/blob/master/openedx/core/djangoapps/dark_lang/middleware.py#L70 However, because of this post https://discuss.overhang.io/t/howto-enable-multiple-languages-for-your-open-edx-platform/140 SD is not using the middleware at all.

Screenshot from 2023-07-05 18-19-56

This is the screenshot of the productive manifest. That's why the PR is being made.