eduNEXT / eox-tenant

Plugin for managing multiple tenants (organizations) within a single Open edX instance.
GNU Affero General Public License v3.0
7 stars 4 forks source link

perf: sumac release support `AP-1580` #230

Open BryanttV opened 4 days ago

BryanttV commented 4 days ago

Description

This PR adds support for the Open edX Sumac release.

These were the changes made:

Testing instructions

  1. Create an environment with Sumac release, you can use Tutor or TVM.
  2. Install the Django plugin eox-tenant using this PR branch, you can use the steps in Tutor documentation.
  3. Run the test cases. In this file, you can find more information about the plugin configuration.

Related Issues

MaferMazu commented 1 day ago

Is there a reason why the integration tests are failing or skipping?

magajh commented 1 day ago

@BryanttV has this been tested in a remote env?

magajh commented 1 day ago

Is there a reason why the integration tests are failing or skipping?

@MaferMazu integration tests in nightly are failing for an unknown error, and as a consequence, the workflows for the other Tutor versions are getting cancelled. I'm going to open a PR with a fix to avoid this

magajh commented 1 day ago

Although since Tutor 19 hasn't been released yet, seems like we have no way to know that the integration tests are passing for Sumac

BryanttV commented 1 day ago

has this been tested in a remote env?

Yes @magajh , the changes were deployed and tested in our Sumac stage.

BryanttV commented 1 day ago

Although since Tutor 19 hasn't been released yet, seems like we have no way to know that the integration tests are passing for Sumac

Should we then wait for the new version of Tutor to merge this PR?

magajh commented 1 day ago

@BryanttV I'd say is not necessary, we can close this PR and open a follow-up task to make sure the tests in Sumac are passing once tutor 19 is released

magajh commented 19 hours ago

@BryanttV can we rebase with this branch https://github.com/eduNEXT/eox-tenant/pull/232 to see if it works?