eduNEXT / eox-theming

Eox Theming | eduNEXT Open edX extensions for theming
GNU Affero General Public License v3.0
3 stars 1 forks source link

feat: Add compatibility with Quince release #52

Closed bra-i-am closed 10 months ago

bra-i-am commented 10 months ago

Depends on

According to the eox-theming test cases document, to test this PR you have to clone ednx-test-themes; in this case because of some changes needed to keep compatibility with Django 4 you need to git checkout it to this PR's branch

Description

This PR adds support to the Quince release updating the Django version, requirements, workflow dependencies, and fixing an issue with a test

Take into account

This PR aims to solve the compatibility among eox-theming and Quince release; despite there are some issues with the ednx-test-themes templates, these are out of the scope of the JIRA ISSUE and the solution will be aborded in future efforts

Testing instructions

  1. Install the plugin, you can:

    • Use OPENEDX_EXTRA_PIP_REQUIREMENTS in the config.yml file
    • Add it with the docker-compose.override.yml to the container and execute pip install <path/to/eox-theming>.
  2. Follow the instructions here.

Additional information

JIRA ISSUE DS-777

MaferMazu commented 10 months ago

Thanks for this PR, @bra-i-am.

The test cases seem to work because when I tried, I obtained this: Screenshot from 2024-01-23 18-12-39 But according to my understanding, the page should be purple, not red. I'm not sure why this is happening.

bra-i-am commented 10 months ago

hi @MaferMazu, the incorrect display of the page (red instead of purple) when tested in the local environment is directly related, allegedly, to issues in the templates of ednx-test-themes. Thus, taking into account that the bragi templates are working properly, this is an out-of-scope issue that will be addressed in future efforts.