search

eduNEXT / wp-edunext-marketing-site

GNU General Public License v2.0
1 stars 0 forks source link

Generic method for api calls was missing a check for Wp_Error instance #24

Closed felipemontoya closed 1 year ago

felipemontoya commented 6 years ago

Pull request :twisted_rightwards_arrows: created by bitbucket user Ivan Castellanos on 2018-09-24 15:39 Last updated on 2018-09-24 16:55 Original Bitbucket pull request id: 24

Participants:

  • bitbucket user felipe montoya (reviewer) :heavy_check_mark:
  • bitbucket user Ivan Castellanos

Source: https://github.com/edunext/wp-edunext-marketing-site/commit/a61670ef70c04523b2d4af670692b9d61392e42a on branch icc/one-wp-error-check-missing Destination: https://github.com/edunext/wp-edunext-marketing-site/commit/ad54b5de17ac65a8cdba795a00585a5f2123f388 on branch master Merge commit: https://github.com/edunext/wp-edunext-marketing-site/commit/2a0620fc24c6f26f6e0bb52178cac18213f3f184

State: MERGED

class-wp-edunext-eox-core-api.php

felipemontoya commented 6 years ago

Bitbucket user felipe montoya commented on 2018-09-24 15:59

Location: line 265 of includes/class-wp-edunext-eox-core-api.php

Is this really what is required here, return the error?
Shouldn't we be calling this->add_notice('error', $error) ?

felipemontoya commented 6 years ago

Bitbucket user Ivan Castellanos commented on 2018-09-24 16:37

Location: line 265 of includes/class-wp-edunext-eox-core-api.php

Is this really what is required here, return the error?
Shouldn't we be calling this->add_notice('error', $error) ?

That happens upper in the stack (the function that calls this function)

felipemontoya commented 6 years ago

Bitbucket user felipe montoya approved :heavy_check_mark: the pull request on 2018-09-24 16:44