eduardconstantin / storybook-gpt

Storybook GPT is a web application for generating Storybook stories from React components using OpenAI API
https://storybook-gpt.vercel.app
MIT License
25 stars 17 forks source link

[Feature] Improve the UI design #4

Closed eduardconstantin closed 1 year ago

eduardconstantin commented 1 year ago

The current design is a bit too dark. I am open to any suggestions about improving the UI design, making it more pleasing.

etnlbck commented 1 year ago

Are you thinking of having something like a toggle between light and dark? Either via a button or detecting user system preferences?

eduardconstantin commented 1 year ago

I was thinking to lighten the dark UI a little bit. I think the shades are too dark. If you think having a dark and a light mode could improve the UI you can try to implement it.

etnlbck commented 1 year ago

I agree. It could use more contrast with a subtle gradient to give dimension. You can assign this issue to me.

etnlbck commented 1 year ago

How do you feel about this for lightening the dark UI?

Screenshot 2023-10-01 at 1 08 38 PM

I also added a responsive class so users can use it on mobile.

Screenshot 2023-10-01 at 1 14 06 PM
eduardconstantin commented 1 year ago

I think it's too much gradient. I don't think anyone will use the mobile version but is a nice addition. Also could you add a margin on the top and bottom? let's say 2-3rem maybe

etnlbck commented 1 year ago

Sounds good. And I agree. The user isn't going to copy/paste their component on mobile.

I'll make the adjustments this evening.

Also, I ran into an issue with theme context and RSC. I haven't worked with RSC before.

eduardconstantin commented 1 year ago

@etnlbck Sounds great! RSC you mean react styled components? Because the project is using tailwind for styling.

etnlbck commented 1 year ago

React Server Components.

Next was cranky when I tried to add the useState hook, because it can only be used on the client. Then I tried adding the recommended "use client" annotation. But since the metadata is exported it gets treated a server.

eduardconstantin commented 1 year ago

I see, server components are the trouble, maybe tailwind can help

eduardconstantin commented 1 year ago

You can leave the theme toggle and focus on the UI for now. Maybe you can create an issue for the toggle.

etnlbck commented 1 year ago

I'll do that. So That I'm not holding up this issue.

etnlbck commented 1 year ago

does this fall in line with what you're thinking. Screenshot 2023-10-07 at 10 43 20 AM

eduardconstantin commented 1 year ago

this looks nice