search

eduardoboucas / include-media

📐 Simple, elegant and maintainable media queries in Sass
https://eduardoboucas.github.io/include-media/
MIT License
2.57k stars 191 forks source link

DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0. #211

Closed sstikkel closed 1 year ago

sstikkel commented 3 years ago

I get a warning regarding line 443 $result: $result + map-get($numbers, $characters) / $digits; Recommendation: math.div(map-get($numbers, $character), $digits) and @use "sass:math":

codiejay commented 3 years ago

hey @sstikkel please can i see your file setup? I can't even manage to setup my own project. i will appreciate any help | #212

Supportic commented 3 years ago

I get a warning regarding line 443 $result: $result + map-get($numbers, $characters) / $digits; Recommendation: math.div(map-get($numbers, $character), $digits) and @use "sass:math":

This is because you are using a newer dart-sass version which encourages you to @use "sass:math" on top of the file and replace the division with math.div.

alexanderalmstrom commented 2 years ago

Any updates on this? We should really fix this to be able to use the latest sass version without getting those division warnings.

jackmcpickle commented 2 years ago

Yeah, might dedicate a day to this over the break. Thinking of a 2.0 release to fix the dart sass stuff and simplify issues.

jackmcpickle commented 2 years ago

Note I've mainly switched to postcss, and i've written. https://www.npmjs.com/package/postcss-include-media

alexanderalmstrom commented 2 years ago

I've created a pull request here https://github.com/eduardoboucas/include-media/pull/214

jackmcpickle commented 1 year ago

resolved in 2.0 release https://github.com/eduardoboucas/include-media/pull/218