search

eduardoboucas / include-media

📐 Simple, elegant and maintainable media queries in Sass
https://eduardoboucas.github.io/include-media/
MIT License
2.57k stars 191 forks source link

Release 2.0 on npm #216

Closed jhildenbiddle closed 1 year ago

jhildenbiddle commented 2 years ago

Are there any plans to publish the 2.0-release branch on npm?

I realize I can install this GitHub branch as a dependency using npm as follows:

npm i -D eduardoboucas/include-media#2.0-release

The issue is that this approach locks the dependency to a specific GitHub branch rather than a semantic version available for packages published on npm which are required for update availability checks via automation or commands like npm outdated.

Thanks!

jackmcpickle commented 2 years ago

Good question. I was thinking about this the other day. @eduardoboucas what are your thoughts? Time to publish?

kevinrodrigues commented 2 years ago

Would also like to know please :)

smarkey commented 2 years ago

Would like to know too please 😃

ashleynolan commented 2 years ago

Would be great to get the v2 version published to NPM – we're currently using it for our CSS setup with @use and @forward and works with no issues.

Even if it can be published and tagged as an alpha/beta release, that would be great so that we didn't have it tied to a github branch.

Twikito commented 1 year ago

Same thing here. We use it at @ProtonMail and it would be great if we didn't have to rely on a specific GitHub branch instead of the latest released version. Please consider publishing 2.0-release branch 🙏

nico3333fr commented 1 year ago

Yes, please please please 🙏

jackmcpickle commented 1 year ago

I would love to but only @eduardoboucas has the rights to publish.

jackmcpickle commented 1 year ago

While we wait for Ed - I did also publish a postcss version of include media a while back - As I mainly use css/postcss stack now.

See https://www.npmjs.com/package/postcss-include-media

eduardoboucas commented 1 year ago

Sorry, I didn't realise I was a blocker here.

@jackmcpickle I tried to add you, but somehow that's not working 😢 

$ npm owner add jackmcpickle include-media

npm ERR! code EOWNERMUTATE
npm ERR! Failed to update package: "404 Not Found - PUT https://registry.npmjs.org/include-media/-rev/28-2068e1a6eba38bef23919fa92caad711 - Team not found"

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/eduardoboucas/.npm/_logs/2023-01-23T11_53_56_202Z-debug-0.log

In the meantime, can you confirm what exactly you want me to publish? Do I just checkout the 2.0-release branch?

jackmcpickle commented 1 year ago

@eduardoboucas yes please publish the 2.0-release branch and then make it the default branch too or merge to main/master.

Twikito commented 1 year ago

@eduardoboucas nice to see you back!

Yes, the 2.0-release branch uses sass modules, so it at least fixes quite a few warnings. 🙏

eduardoboucas commented 1 year ago

I have published version 2.0.0 from the 2.0-release branch.

@jackmcpickle I've created https://github.com/eduardoboucas/include-media/pull/218, can you please review and merge?

jackmcpickle commented 1 year ago

Done. Thanks @eduardoboucas.

I think we can offical close this issue now. :)

nico3333fr commented 1 year ago

Thanks a lot to all of you 🙏

Twikito commented 1 year ago

Thanks a lot 🎉

Twikito commented 1 year ago

And could you create a release so that we could install the package via npm? 🙏

jhildenbiddle commented 1 year ago

Thank you!

cmalven commented 1 year ago

It would be nice to have this listed as an official release (with change notes) https://github.com/eduardoboucas/include-media/releases

It's a bit confusing right now that the releases end at 1.4.x, the listed tags end at 1.4.x, and yet the version on npm is 2.0

jackmcpickle commented 1 year ago

@cmalven published release now. Thanks for the reminder.