eduardoboucas / include-media

📐 Simple, elegant and maintainable media queries in Sass
https://eduardoboucas.github.io/include-media/
MIT License
2.57k stars 191 forks source link

Feature/add conatiner queries #225

Open jackmcpickle opened 1 year ago

jackmcpickle commented 1 year ago

Addresses https://github.com/eduardoboucas/include-media/issues/223 by adding container mixin

Currently some issue with sass-true and container mixin. Maybe a bug?

jackmcpickle commented 1 year ago

@andreimoment Review?

andreimoment commented 1 year ago

@jackmcpickle thank you for submitting these. I noticed a few things:

Note, I am not a maintainer for this - just someone who suggested adding the feature. I apologize for not acting on this sooner - SCSS is not my forte and it will take me a bit of time to understand all of the code and propose an update.

Thank you for acting swiftly and moving this in the right direction.

jackmcpickle commented 1 year ago

@andreimoment all good. I thought I'd just start with the unnamed @container queries for now.