search

eduardoboucas / include-media

📐 Simple, elegant and maintainable media queries in Sass
https://eduardoboucas.github.io/include-media/
MIT License
2.57k stars 191 forks source link

Fix Dart Sass deprecation warning - global built-in function str-leng… #233

Closed posttoast closed 1 week ago

posttoast commented 1 week ago

Fix Dart Sass deprecation warning - global built-in function str-length and str-slice are deprecated, changed to string.length and string.slice.

jackmcpickle commented 1 week ago

Thanks @posttoast , but you will need to change in the src too src/helpers/_trim.scss

jackmcpickle commented 1 week ago

Note I've just pushed a change to master to update the sass package and fix warnings in the tests. If you want to rebase

posttoast commented 1 week ago

Thanks, I updated the pull request :)

jackmcpickle commented 1 week ago

Issue with the github node runner atm. https://github.com/npm/cli/issues/7814 - but looks good will merge.

jackmcpickle commented 1 week ago

Thanks for picking up @posttoast