search

eduardoboucas / staticman

💪 User-generated content for Git-powered websites
https://staticman.net
MIT License
2.41k stars 531 forks source link

Email notification sent for every subscriber to every other subscriber #182

Open binarymist opened 6 years ago

binarymist commented 6 years ago

Here is the scenario:

I have a blog post: https://binarymist.io/blog/2018/02/24/hugo-with-staticman-commenting-and-subscriptions/

At the time of submitting this, there are three commenters, of which all have subscribed. When any one of the existing commenters including myself submits a comment and I accept the github pull request, each of the existing two commenters/subscribers, are sent two email notifications for every new comment and I am sent three email notifications for the same.

Do we have any idea what is causing this behaviour @eduardoboucas?

binarymist commented 6 years ago

I notice that Staticman processEntry and processMerge both send the email notification, is this the fault or maybe something else. Let me know if you need help replicating or testing?

binarymist commented 6 years ago

Any progress with this @eduardoboucas?

binarymist commented 5 years ago

Is no one else having this issue @eduardoboucas?

binarymist commented 5 years ago

I've recently upgraded to v3 bsed on #243, and it seems that the duplicates are not happening.

binarymist commented 3 years ago

Did I speak too soon? #420