eduardoboucas / staticman

💪 User-generated content for Git-powered websites
https://staticman.net
MIT License
2.42k stars 540 forks source link

staticman failing to create pull request #217

Closed hendrixjoseph closed 6 years ago

hendrixjoseph commented 6 years ago

Steps to reproduce:

Result: an error dialog appears ("Error Sorry, there was an error with the submission!")

A new branch will be created, but there will be no pull request. For instance, this is the file in the branch when I tried - https://github.com/eduardoboucas/popcorn/blob/staticman_d5564aa0-86cd-11e8-bce9-2fc4fd410763/_data/reviews/entry1531507924416.yml

I notices this on my own blog as well, but got a more detailed response:

{
   "success":false,
   "rawError":{
      "code":403,
      "status":"Forbidden",
      "message":"{\"message\":\"At least one email address must be verified to do that.\",
           \"documentation_url\":\"https://help.github.com/articles/adding-an-email-address-to-your-github-account\"}"
   },
   "errorCode":"GITHUB_CREATING_PR"
}
MiKatre commented 6 years ago

Exact same issue with my two websites using staticman:

{
   "success":false,
   "rawError":{
      "code":403,
      "status":"Forbidden",
      "message":"{\"message\":\"At least one email address must be verified to do that.\",
           \"documentation_url\":\"https://help.github.com/articles/adding-an-email-address-to-your-github-account\"}"
   },
   "errorCode":"GITHUB_CREATING_PR"
}
hendrixjoseph commented 6 years ago

I just verified that this is the same error from the Popcorn demo site

{
    "success": false,
    "rawError": {
        "code": 403,
        "status": "Forbidden",
        "message": "{\"message\":\"At least one email address must be verified to do that.\",\"documentation_url\":\"https://help.github.com/articles/adding-an-email-address-to-your-github-account\"}"
    },
    "errorCode": "GITHUB_CREATING_PR"
}

is this some change in github's platform, or is there no email associated with staticman?

also, if I go to the GitHub page for @staticmanapp (https://github.com/staticmanapp) I get a 500 server error. it doesn't happen with anyone else's user page

nfreear commented 6 years ago

Hi @eduardoboucas,

I see the same issue as reported by @hendrixjoseph and @MiKatre on my blog,

Yours,

Nick

GonzaloZiadi commented 6 years ago

Facing this same issue as well.

jloisel commented 6 years ago

:+1: on this. Same issue here.

eduardoboucas commented 6 years ago

Something really odd is going on. When I try to sign in to GitHub as staticmanapp (the user account used by the public instance to create the pull requests), I get that 500 page. No additional information whatsoever.

I'll try to find out what's going on, but it's definitely something that changed on the GitHub side.

Stanko commented 6 years ago

It seems that bot account has no verified email address set. It is probably security change on the github side. I think verifying email address would probably solve it.

https://help.github.com/articles/verifying-your-email-address/

eduardoboucas commented 6 years ago

I thought the email was verified, but apparently that wasn't the case. Anyway, I managed to do this, but I still see a 500 page when I try to access the profile.

Can anyone confirm if the API errors still persist?

Thanks!

Stanko commented 6 years ago

@eduardoboucas works here! Thank you for the fast turnaround! 🎉

hendrixjoseph commented 6 years ago

all good here. @staticmanapp is no longer showing a 500 error for me either https://github.com/staticmanapp

jloisel commented 6 years ago

I confirm it's working on our side too.

eduardoboucas commented 6 years ago

Great. Thanks all!