eduardok / libsmbclient-php

smbclient's extension for PHP
Other
99 stars 21 forks source link

Fix incorrect info for smbclient_state_init #75

Closed peterg98 closed 3 years ago

peterg98 commented 3 years ago

I've noticed that smbclient_state_init returns an integer (0 for success, 1 for failure) rather than a boolean. Since 1 gets evaluated to True it actually does the opposite of what is on the README.

eduardok commented 3 years ago

php_smbclient_state_init returns int, but smbclient_state_init returns bool, if I'm reading it correctly.

peterg98 commented 3 years ago

Pretty much, yes. Just a minor thing that confused me while I was working on a project with this library