search

eduardolat / pgbackweb

🐘 Effortless PostgreSQL backups with a user-friendly web interface! 🌐💾
MIT License
716 stars 30 forks source link

Feat/display backup size #26

Closed julien-wff closed 1 month ago

julien-wff commented 1 month ago

Hi there!

Thank you very much for making this piece of software. A GUI database backup project has been on my todo list for a long time, but I'll use yours since it's pretty good!

When using pgbackweb, I wished the size of the backups would be displayed, so I made it. Hope you think it fits the project!

Since I don't think we can't get the size of an io.Reader without consuming the stream, I had to pull the file size from the destinations. I just returned a simple int64, but I wonder if a struct with a single field would not be better for code sustainability.

image image

Backups prior to this PR simply won't have a display size

eduardolat commented 1 month ago

Hi @julien-wff I hope you enjoy the project as much as I do.

Let me thank you for your contribution to the project, it is something necessary and you implemented it perfectly according to the rest of the project.

We will leave your implementation as is, and if we need to return something additional to the file size in the future then we will create the struct.

Your changes will be included in the next release, thank you very much for your time to contribute <3

Jogai commented 3 weeks ago

Thank you both. Luis for the project, and Julien for this useful addition.