Open fuweichin opened 4 years ago
Overview: gulp-umd templates is out of sync with umdjs templates.
The Problem: As the 'global' check algorithm gulp-umd currently using in templates is deprecated, files generated gulp-umd have two serious problems:
import '/node_modules/js-untar/build/dist/untar.js';
The error looks like:
Cannot set property 'xxx' of undefined
because the outer this, or argument root in IIF, is undefined
this
root
undefined
see InvokIT/js-untar#30 and markedjs/marked#1292
Possible Solution: Update the global check algorithm to umdjs's latest recommended way.
say, replace this with typeof self !== 'undefined' ? self : this, see returnExportsGlobal.js for example.
typeof self !== 'undefined' ? self : this
This is a serious problem, plz patch latest 3 versions (2.x, 1.x anf 0.2.x), also set deprecated tag on old versions at npm central registry.
Overview: gulp-umd templates is out of sync with umdjs templates.
The Problem: As the 'global' check algorithm gulp-umd currently using in templates is deprecated, files generated gulp-umd have two serious problems:
import '/node_modules/js-untar/build/dist/untar.js';The error looks like:
because the outer
this, or argumentrootin IIF, isundefinedsee InvokIT/js-untar#30 and markedjs/marked#1292
Possible Solution: Update the global check algorithm to umdjs's latest recommended way.
say, replace
thiswithtypeof self !== 'undefined' ? self : this, see returnExportsGlobal.js for example.This is a serious problem, plz patch latest 3 versions (2.x, 1.x anf 0.2.x), also set deprecated tag on old versions at npm central registry.