search

eduardolundgren / gulp-umd

Gulp plugin for build JavaScript files as Universal Module Definition, aka UMD
MIT License
126 stars 14 forks source link

Fixed wrong syntax for gulp.dest() in doc #7

Closed amercier closed 9 years ago

amercier commented 9 years ago

Using the code given in the documentation throws the following error:

[14:11:37] TypeError: Object #<Stream> has no method 'dest'
    at Gulp.<anonymous> (.../gulpfile.js:11:6)
    at module.exports (.../node_modules/gulp/node_modules/orchestrator/lib/runTask.js:34:7)
    at Gulp.Orchestrator._runTask (.../node_modules/gulp/node_modules/orchestrator/index.js:273:3)
    at Gulp.Orchestrator._runStep (.../node_modules/gulp/node_modules/orchestrator/index.js:214:10)
    at Gulp.Orchestrator.start (.../node_modules/gulp/node_modules/orchestrator/index.js:134:8)
    at .../node_modules/gulp/bin/gulp.js:129:20
    at process._tickCallback (node.js:419:13)
    at Function.Module.runMain (module.js:499:11)
    at startup (node.js:119:16)
    at node.js:906:3

This is due to a mistake* in the docs: .dest(build) must be replaced by .pipe(gulp.dest ('build')). Please refer to Gulp API Documentation for details.

This PR fixes the issue.

*: or could be due to a change in Gulp API

eduardolundgren commented 9 years ago

LGTM, thanks.