bug in tracking...

[publicocean0]

colors.on('track', function(event) { if (event.data.length > 0&&!component.prop('tracked')) { component.prop('tracked',true) colors.removeAllListeners(); $this.stop(); } });

the video seams go slower ... maybe colors continue to work .... how can i destroy the tracker ?

[publicocean0]

added tracker.stop();

[publicocean0]

there is apparently a bug ... i dont know if your lib or in browser....

i m using dash.js and your lib.... when i add your lib ... even if stopped.... continue to get slow the player

[publicocean0]

in chrome it tracked the frame but then player goes slow , in firefox tracking dont find frames until timeout

[publicocean0]

for now i disabled this feature because dont work as expected

[publicocean0]

i post the code used

var trackPoster=function(){
          if (isUrl && source.startsWith('rtmp://')) return; // to do .. try to solve
          component.prop('tracking',true)
          component.prop('tracked',false)
          setTimeout(function(){

            if (!component.prop('tracked')) { 
                component.prop('tracked',true)

                colors.removeAllListeners();
                tracker.stop();
                $this.stop();
                console.log('not tracked poster:forced to stop')

            }  
          },5000)
          var colors = new tracking.ColorTracker(['magenta', 'cyan', 'yellow']);

          colors.on('track', function(event) {
            if (event.data.length > 0&&!component.prop('tracked')) {
                component.prop('tracked',true)

                colors.removeAllListeners();
                tracker.stop();
                $this.stop();
                console.log('tracked poster')
            }
          });

          var tracker =tracking.track(component[0], colors);
     } 

[revolunet]

unreadable issue

https://upthemes.com/blog/2014/02/writing-useful-github-issues/

[publicocean0]

what do you need ? i have also to tell you where is the bug and to fix it? ahahaha

[revolunet]

what about trying to format your code correctly ? i'm pretty sure it helps in readability...

also having a reproductible test case helps eventual contributors to fix the bug faster :)

[publicocean0]

It is first time in my life a developer ask me about formality instead eventually ask about content .I worked in thousands of projects. Ah ah you are a "strange" developer but you are nice Il 04/lug/2017 15:02 "Julien Bouquillon" notifications@github.com ha scritto:

what about trying to format your code correctly ? i'm pretty sure it helps in readability...

also having a reproductible test case helps eventual contributors to fix the bug faster :)

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/eduardolundgren/tracking.js/issues/227#issuecomment-312872475, or mute the thread https://github.com/notifications/unsubscribe-auth/ACZspBRNV93BrThQeLJahbsC12ULHC4rks5sKjfegaJpZM4N8RuW .

[jeromeetienne]

@publicocean0 what @revolunet is asking you is reasonable and useful. please do it, without it, we cant help you.