eduardolundgren / tracking.js

A modern approach for Computer Vision on the web
http://trackingjs.com
Other
9.44k stars 1.45k forks source link

Add support for Safari 11/remove deprecated getUserMedia API #228

Closed ted-piotrowski closed 7 years ago

ted-piotrowski commented 7 years ago

First off, thank you for a great library. I managed to implement my pet project Slouch cam with minimal effort. Thank you! (I did offload the ViolaJones computations onto a worker thread to improve responsiveness. Happy to share this work if interested.)

My issue is more pragmatic. Safari 11.0 will be implementing User Media functionality, however, they will be using the newer navigator.mediaDevices.getUserMedia api, instead of the deprecated navigator.getUserMedia. Support for this newer version of getUserMedia does not exist in tracking.js.

PR: https://github.com/eduardolundgren/tracking.js/pull/229

jeromeetienne commented 7 years ago

It has been merged. thanks for the contribution :)

tschiemer commented 5 years ago

heja! Thanks for the library!

Just a sidenote, it would seem that on the official website you still are using version 1.1.2 wherein this fix (as of 1.1.3) is not yet included.

https://trackingjs.com/bower/tracking.js/build/tracking-min.js