search

eduardomb / scroll-up-bar

The scroll up bar plugin (jQuery) hides the top bar when scrolling down, and show it when scrolling up. It's specially useful on mobile interfaces to save some precious space.
MIT License
612 stars 63 forks source link

Update scroll-up-bar.js #2

Closed wsh9000 closed 10 years ago

wsh9000 commented 10 years ago

deal with IE11(not sure if other IE version has this problem) (when you scroll-up with mouse wheel,scroll-down also triggered,cause the top bar hidden) (in fact,not like chrome,scroll with mouse wheel triggered scroll event serveal times) but I find when it happened,"y==lastY"(var in the js),so I simply add "if (y==lastY){return;}",now it work on IE11 right,:-P

eduardomb commented 10 years ago

Good catch. Multi browser support is very important for a plugin like this. Thanks for the PR. One suggestion for your fix, with I commented on. Also, can you update the min.js file?

wsh9000 commented 10 years ago

it looks better now,and the min.js is updated.

eduardomb commented 10 years ago

Thank you. One last thing before I merge it: squash your commits into one to have a cleaner history.

eduardomb commented 10 years ago

Resolved on #3