Peer to peer code review

eduardosancho / awesome_books

Awesome books is a single-page-application that shows a library of books that will be stored in the computer's local storage. The user can freely add and remove books. Built with HTML / CSS / JavaScript

5 stars 0 forks source link

Peer to peer code review #6

Open Yothu opened 2 years ago

Yothu commented 2 years ago

I would recommend dismantling the removeBook and displayBooks functions in a way that they only handle data from its objects, for example:

The removeBook function filters the book array but it also saves the array in the local storage and displays the books. I would recommend putting the last 2 operations outside of the removeBook function.

eduardosancho commented 2 years ago

Thank you, that is actually a good way to solve the linter suggestion that we have right now. We will look into it, thank you very much.

gdumani commented 2 years ago

The input form doesn't should clean the form when a new book is added