search

edubart / otclient

An alternative tibia client for otserv written in C++11 and Lua, made with a modular system that uses lua scripts for ingame interface and functionality, making otclient flexible and easy to customize
Other
652 stars 399 forks source link

Debian/Ubuntu instructions on Wiki are not matching Dockerfile #1202

Open GustavoContreiras opened 1 year ago

GustavoContreiras commented 1 year ago

The wiki is saying that the packages for Ubuntu are

build-essential 
cmake 
git-core
libboost-all-dev 
libphysfs-dev 
libssl-dev 
liblua5.1-0-dev 
libglew-dev 
libvorbis-dev 
libopenal-dev 
zlib1g-dev

And the dockerfile uses the following packages

build-essential 
cmake 
git-core 
libboost-atomic1.65-dev 
libboost-chrono1.65-dev 
libboost-date-time1.65-dev 
libboost-filesystem1.65-dev 
libboost-system1.65-dev 
libboost-thread1.65-dev 
libglew-dev 
liblua5.1-0-dev 
libncurses5-dev 
libopenal-dev 
libssl-dev 
libvorbis-dev 
zlib1g-dev

Also dockerfile is using a specific commit version of Ubuntu while the github pipeline is using Ubuntu 20.04. The pipeline for ubuntu, the dockerfile and the wiki instructions for ubuntu should be matching, shouldn't?

IntinteDAO commented 1 year ago

The only difference is libncurses5-dev, but it's console specified package, so not sure if required. libboost-all-dev is metapackage that contains all libboost packages