edubart / otclient

An alternative tibia client for otserv written in C++11 and Lua, made with a modular system that uses lua scripts for ingame interface and functionality, making otclient flexible and easy to customize
Other
640 stars 402 forks source link

wrong repo #1206

Closed tornadia closed 1 year ago

tornadia commented 1 year ago

As some of you know, after the introduction of Jiddo's NPC system, which greatly helped the community, there has been but one bad thing of it becoming a convoluted mess from keeping Mark's 10 year old codebase and re-introducing Jiddo's system. Some of the legacy code is still remaining within TFS, but unused at all.

I will describe a bug remnant from those changes.

Before creating an issue, please ensure:

Steps to reproduce (include any configuration/script required to reproduce)

  1. Say one of the greetwords to an npc. image image

  2. Say one of the keywords to the npc, it will work as expected. image

  3. If you say that keyword again, but include the word "hi", this time it will not work. image

  4. Or for a better illustrative example, include a word with "hi" inside of it. image

  5. See in the last example, using the words "pink" worked, but "white" didn't, because of the "hi" in "white".

Expected behaviour

Should process it in npcsystem

Actual behaviour

Doesn't

Proposed fix

image image

Environment

Linux


I can submit a PR for it if needed. I believe this repository is abandoned, but I am informing you in case somebody else will find it relevant.

tornadia commented 1 year ago

Wrong repo. https://github.com/otland/forgottenserver/issues/4397