move temp file to current file's directory

edubkendo / atom-racer

Intelligent code completion for Rust in the Atom Editor. Requires Racer.

MIT License

115 stars 24 forks source link

move temp file to current file's directory #30

Closed cart closed 9 years ago

cart commented 9 years ago

Racer will not complete correctly on Linux (and possibly other operating systems) unless the file given to it is in the proper directory. I moved the temporary files from the project root to the directory of their original file.

alkama commented 9 years ago

As a more general sidenote, I've checked the vim plugin implementation and it seems that once the temp file is written somewhere in the project, it's useless to add the project to the RUST_SRC_PATH at all.

So maybe a good plan would be to:

use the projects path as the temporary file root in case of a new (never saved as a file before) buffer. So that racer can still find cargo and all.
use the editors path for the normal case.
remove the project path and separator we add in the building on RUST_SRC_PATH

Dont you think?

cart commented 9 years ago

Yeah that definitely seems like the right way to do it.

cart commented 9 years ago

I apologize for the delay. Do those changes look good?

alkama commented 9 years ago

No problem :) Looks fine to me now ! Thanks for your contribution !

alkama commented 9 years ago

@edubkendo this should be good for a v0.14.0 :)

Note: In an upcoming update, I'll fix:

the package.json for contributors,
readme to give clues about how to hide the temp files in the treeview (so that it dont flickers),
the changelog so that it's up to date.

edubkendo commented 9 years ago

Done :smile: