avoid collision of key binding on win32 and linux

edubkendo / atom-racer

Intelligent code completion for Rust in the Atom Editor. Requires Racer.

MIT License

115 stars 24 forks source link

avoid collision of key binding on win32 and linux #43

Open colin-kiegel opened 8 years ago

colin-kiegel commented 8 years ago

atom-core defines this keybindings for 'f3' but none for 'f1'

'.platform-win32 atom-text-editor, .platform-linux atom-text-editor': 'f3': 'find-and-replace:find-next'

This pull requests makes the racer-keybinding work on win32 and linux by default.

alkama commented 8 years ago

Those collisions are unavoidable and noone can tell that F1 wont collide with something else that ppl use. Wouldn't it be better to document in the Readme how each user can bind the feature to his favorite key?

colin-kiegel commented 8 years ago

@alkama: Yes and No.

Yes: General collisions of key-bindings of other packages are unavoidable. And noone can tell that F1 wont collide with something else that ppl use.
and No: This is a collision with atom-core (not on osx, but on linux and on windows). Those can and should be avoided imo.

alkama commented 8 years ago

Makes sense

colin-kiegel commented 8 years ago

Of course one should check if the alternative F1 collides with OS key bindings (like help) on windows and osx. It works fine on ubuntu gnome.