search

edubkendo / atom-racer

Intelligent code completion for Rust in the Atom Editor. Requires Racer.
MIT License
115 stars 24 forks source link

"find-definition" is not work(windows) #49

Open armink opened 8 years ago

armink commented 8 years ago

Default key is F3. But it's not work on my Atom. When I add 

'atom-text-editor':
  'f1': 'racer:find-definition'

to my keymap.cson file. The "find-definition" function can work well by F1 key. I think F3 is good key for "find-definition". Because the Eclipse also use this key. So how can I use F3 for "find-definition" on my Atom.

majkcramer commented 8 years ago

Same Issue here. F3 does not work. F1 works.

OS: windows8 64bit Rust: rustc 1.4.0 stable Atom: 1.2.4

xamgore commented 8 years ago

:+1: the same problem

ligoore commented 8 years ago

Default key is F3, which does not work. Overriding does not work also. 

'atom-text-editor':
    'f1': 'racer:find-definition'

Windows 10, Atom 1.6.0, racer 0.18.0

Diggsey commented 8 years ago

I have the same problem - I think it conflicts with the use of F3 for find-next within atom. Should probably choose a different default!

edubkendo commented 8 years ago

There's a pull request (https://github.com/edubkendo/atom-racer/pull/43) to change this to F1 but if that's not working for some people either, I'm not sure what it should be. Let's have a conversation about what would be best for all systems. pinging @colin-kiegel and @alkama

colin-kiegel commented 8 years ago

Thank you. As I have written in my pull-request, anything that does not collide with atom-core key-bindings would be better than the status-quo.

I just checked my keymaps (on linux), free F-keys are F1 and F4...F9.

I understand your concerns about F1, but what about F4 then? It's close to F3. ;-)

kanekv commented 7 years ago

find definition doesn't work for me at all, overrides don't work too