added functionality to make atom-racer find racer_bin on the path

edubkendo / atom-racer

Intelligent code completion for Rust in the Atom Editor. Requires Racer.

MIT License

115 stars 24 forks source link

added functionality to make atom-racer find racer_bin on the path #60

Open junewunder opened 8 years ago

junewunder commented 8 years ago

cleaned up some code
added a for-loop for loop through the process.env.PATH and find the racer binary

junewunder commented 8 years ago

I added a function find_racer_path which loops through the process.env.PATH to find something with the last element as "racer"

edubkendo commented 8 years ago

Nice work! which OS'es has this been tested on?

junewunder commented 8 years ago

I only have OSX. Now that I think of it, there might be issues on Windows because it separates the path with "/" and not "\". But that just mean it shouldn't work on windows. Not break it entirely.

junewunder commented 8 years ago

I could use regex instead...

edubkendo commented 8 years ago

Would love for someone to test this out on Windows and get this rebased and merged in.

junewunder commented 8 years ago

oh! I had forgotten about this pull request, I'll try to get this working

Xaeroxe commented 6 years ago

This functionality has been added to https://github.com/Xaeroxe/atom-racer and published as racer-plus

junewunder commented 6 years ago

Thanks!