search

educational-technology-collective / etc_jupyterlab_telemetry_library

BSD 3-Clause "New" or "Revised" License
3 stars 2 forks source link

Recommendation: Remove optional dependency on IETCJupyterLabNotebookStateProvider and Test #3

Open adpatter opened 1 year ago

adpatter commented 1 year ago

The optional dependency should be removed. I put it there in order to making testing "easy"; however, this will confuse anyone who wants to consume this extension, as it isn't necessary in order to consume the events.

Also all of the commented "TEST" code should be removed: https://github.com/educational-technology-collective/etc_jupyterlab_telemetry_library/blob/96d951df31132a4a4d2914491e227074f8e0f8fd/src/index.ts#L63

@cab938 @mengyanw Please let me know if you would like for me to do this once @mengyanw has merged her changes.

adpatter commented 1 year ago

There should be another extension that consumes this extension for testing i.e., it should just log events to the console. It could be named something like etc_jupyterlab_telemetry_library_test. @cab938 @mengyanw Please let me know if you would like for me to implement that.

mengyanw commented 1 year ago

@adpatter The dependency was removed in the recent commits. https://github.com/educational-technology-collective/etc_jupyterlab_telemetry_library/commits/mengyan