search

educational-technology-collective / morf

The MOOC Replication Framework (MORF)
MIT License
16 stars 7 forks source link

Use logging throughout config functions #57

Open jpgard opened 6 years ago

jpgard commented 6 years ago

Should be no print statements, and all output and exceptions should be logged somewhere. Note that this module has to deal with the unique challenge of logging before the config files have been combined, and will need to write logging to someplace logical with that in mind (maybe to the default morf or morf-listener logger, or...?)

https://github.com/educational-technology-collective/morf/blob/01929ff9985abc67e17884a74c3629a588949226/morf-python-api/morf/utils/config.py#L30

jpgard commented 6 years ago

can probably use set_logger_handlers(module_logger, job_config=None), just as is used throughout functions in morf.utils