educational-technology-collective / morf

The MOOC Replication Framework (MORF)
MIT License
16 stars 7 forks source link

Attribute error in __init__.get_bucket_from_url(url) and get_key_from(url) #70

Open mileyyao opened 5 years ago

mileyyao commented 5 years ago

get_bucket_from_url(url) and get_key_from(url) only take URL using s3:// protocol but "Amazon S3 supports both virtual-hosted–style and path-style URLs to access a bucket." (ref: https://docs.aws.amazon.com/AmazonS3/latest/dev/UsingBucket.html)

Therefore when the API tries to extract the key and bucket from my s3 bucket https URL, it raises an attribute error.